Could be done in that way, but there can happen weird behaviour:

• Asking about replace file which exists, there is file with the same name without ext
• click [ok] - saved file, without overriding,
• user will have two files.

There is another bug:

orange-canvas-core 0.2.6

1. Open new workflow and writing name of it with file already exists in recent localization
2. Save when "modified" indicator is visible.
3. Click "Reject/Cancel"
4. Workflow is saved, no notification to user! existing file is replaced.

Second commit fix mentioned bug.

Thank you for this PR, and sorry that we took so long to look into it.

I especially appreciate the fix for the correct treatment of clicking on the "Cancel" in the dialog. That was a nasty bug.

I like the idea of keeping the .ows extension, but now this PR introduced a new bug. Let's assume a file "a.ows" already exists. Then, the user saves their workflow into "a". Now, the code silently add ".ows" and this the user is not notified that they are overwriting an existing file. So that silent addition of ".ows" is dangerous.

We did attempt to handle this in the Save widget and the solution in owsavebase.py (from biolab/orange3) was to manually put up an additional dialog if needed. We could do something similar here. So the crux is this:

                if not os.path.exists(filename) or QMessageBox.question(
                        self, "Overwrite file?",
                        f"File {os.path.split(filename)[1]} already exists.\n"
                        "Overwrite?") == QMessageBox.Yes:

owsavebase.py handles different platforms separately, but I think the above "post-processing" of the dialog results should work with all platforms. Could you try a similar patch?

Please also rebase to master. If you perhaps don't have time to work on this PR, please tell us, so that we can add the check ourselves. Thank you!

Yup, I know about that weird behaviour, but in that moment I cannot figure out where is the best place to do this. So what I was thinking, was compromise. 😎
Now that feature is in right place, I understood that thing about assigned 'path' when file was previously saved.

Thanks for this override snippet - added.

/rebase

I don't get one thing. When I run tests at my machine I have to still accept manually dialog with "override", even though the settings: AcceptSave and DontConfirmOverwrite are set. 😑

Maybe here will not ask, but if yes - any ideas?

Confirmation comes a few lines later in the code, where it calls QMessageBox. To avoid this, you need to patch the MessageBox.question, like this (the first patch is already there, just add the second line and the necessary imports):

        with patch("AnyQt.QtWidgets.QFileDialog.exec", exec), \
            patch("AnyQt.QtWidgets.QMessageBox.question", new=Mock(return_value=QMessageBox.Yes)):

@markotoplak, after you approve the PR (please also add a comment so I get an email), I can update the translations and merge.

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.08%. Comparing base (840d84c) to head (8141870).

@@           Coverage Diff           @@
##           master     #330   +/-   ##
=======================================
  Coverage   76.07%   76.08%           
=======================================
  Files         102      102           
  Lines       21326    21321    -5     
=======================================
- Hits        16224    16222    -2     
+ Misses       5102     5099    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

I don't like this mechanism. There is enough to write name as "title.o" to skip this at all and save file which can't be found...
But I think this is the most elegant solution without complicate things further.

Anyway that fix of "saving at cancel" is more important.

For the sake of clarity, to be equal with master I did:

rebase master
git push --force
git reset --soft abe7ba9 # no changes just squash commits
git push --force # --force because of reset

I like your last solution and it seems to work for me! Thanks for taking the time and effort to produce something better than we suggested.